Go: Add models-as-data content for pointer content#13454
Merged
owen-mc merged 3 commits intogithub:mainfrom Jun 20, 2023
Merged
Go: Add models-as-data content for pointer content#13454owen-mc merged 3 commits intogithub:mainfrom
owen-mc merged 3 commits intogithub:mainfrom
Conversation
smowton
previously approved these changes
Jun 14, 2023
owen-mc
force-pushed
the
go/add-mad-content-for-pointer-content
branch
from
d9faee1 to
8b292fa
Compare
owen-mc
changed the title
Contributor
|
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Really cool with an extension to the MaD DSL for GO :-)
| or | ||
| component = "MapValue" and content instanceof DataFlow::MapValueContent | ||
| or | ||
| component = "Dereference" and content instanceof DataFlow::PointerContent |
Contributor
There was a problem hiding this comment.
Consider updating the header comment in this file for input/output that it is now possible to use "Dereference" as a part of an access path.
Contributor
Author
There was a problem hiding this comment.
Access paths weren't mentioned. I've copied what C# says about it and updated it to newer syntax without "of". I've taken the liberty of updating the C# one as well.
owen-mc
force-pushed
the
go/add-mad-content-for-pointer-content
branch
from
8b292fa to
04ff89e
Compare
michaelnebel
approved these changes
Jun 20, 2023
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Looks good to me and thank you for the C# update as well 👍
smowton
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #13453 and fixes the failing tests added in that PR.